Extract object size information from the PDB#36
Merged
Conversation
- When possible, deduce the size of an object symbol from the type information associated with it - Deduce the sizes of floats, doubles, strings, and wide strings from the decorated names of their symbols
- Projects can add use_pdb_types: false to their config.ymls to avoid TPI parsing, e.g. if the type data in their PDB does not parse correctly
- This function interferes with PDB-aided analysis, from which we already get accurate .pdata splits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_pdb_typesconfig key to avoid breaking some projectsupdate_splitsfrom running whilequick_analysis: true, which is how PDB-based projects should be configured