fix(cli): bound cold subscribe so large channels can post - #19
Open
femzyomos wants to merge 1 commit into
Open
Conversation
Full-history syncRoom (since_seq 0) can exceed ProtocolClient's 5s inter-frame wait on large channels, timing out post/status/inbox. Pass hydrate_limit on cold subscribe and raise the sync frame wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncRoomcold-subscribes withsince_seq: 0. On large channels, replaying full history can exceedProtocolClient's default 5s inter-frame wait and failcodor post/status/inboxwithtimed out waiting for server frame.hydrate_limiton cold subscribe (500) and raise the sync frame wait to 60s so bounded cold snapshots finish reliably.Why
Live dogfood: a channel with ~10k messages took ~8s to full-sync with inter-frame gaps >5s.
codor post -r <that-channel>timed out; smaller channels posted fine. After this change, post succeeded in ~3–4s.Test plan
pnpm --filter @codor/cli buildpnpm --filter @codor/cli exec vitest run src/index.spec.ts -t "post"(6 passed)collaboration-room-syncif required (contributor path per CONTRIBUTING — describe intent here; did not edit.harn/)