fix: use bracket notation for statsd keyword list access in init/1#74
Merged
Merged
Conversation
Adds a regression test to assert peep starts successfully when statsd options are configured. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
fix/statsd-opts-keyword-list-access
branch
from
ea855ee to
45bc17b
Compare
Contributor
Author
|
hey @rkallos can you help me on this one? It is blocking the upgrading 😢 |
Owner
|
D'oh! Nice find! I'm on vacation right now, and I get back on Saturday. I can play around, merge and release it then. |
Owner
|
Thanks for the fix! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BadMapErrorcrash on startup whenstatsdoptions are configuredstatsd_optsis a keyword list (per thePeep.Optionsschema:type: {:or, [nil, {:keyword_list, ...}]}), so it must be accessed with bracket notation, not dot notationstatsd_opts[:flush_interval_ms]correctly — line 215 was inconsistentThe bug was introduced in v5.0.0 when
optionswas refactored from a keyword list to a%Peep.Options{}struct. The dot-notation conversion was incorrectly applied tostatsd_opts, which is a keyword list field inside the struct.