fix(neo4j): splitStatements only splits on RETURN#5
Merged
Conversation
The splitStatements function incorrectly treated CREATE as a statement starter keyword. This caused multi-CREATE queries like fixtures to be split into separate statements, losing MATCH context and creating orphan nodes with relationships to undefined variables. Changes: - Remove CREATE from starterKeywords (it can chain within a statement) - Change isComplete() to only return true for statements with RETURN - This keeps chained CREATE clauses together as a single Cypher statement
Owner
|
Add tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: splitStatements only splits on RETURN
isComplete()was too aggressive - treated any write keyword (CREATE/MERGE/DELETE) as "complete", causing premature splits that broke variable bindings in chained CREATE clauses.Bug case
Was split into 3 statements -
bobandc1became undefined in subsequent statements, creating orphan nodes.Change
Starter keywords unchanged (MATCH, CREATE, MERGE, DETACH, OPTIONAL, CALL, UNWIND, FOREACH).
Result
MATCH...CREATE...CREATEstays together (no RETURN)...RETURN xthenCREATE/MATCH...splits correctly