Copy canvas contents when creating a drag image#157
Open
Zohenn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As MDN documentation for
cloneNodestates (https://developer.mozilla.org/en-US/docs/Web/API/Node/cloneNode), if this method is used on acanvaselement, the painted image is not copied.I am currently refactoring a Svelte app to use Vue and the library I used for Svelte handled that case. You can check their solution at https://github.com/isaacHagoel/svelte-dnd-action/blob/2d1190619d9259c7f5ffd858bd4bf8a2ad76e7ad/src/helpers/svelteNodeClone.js. I did the same for this library, only without explicit copying of width and height attributes, as those are copied by
cloneNode.Here's how it worked before:
Screencast From 2025-06-16 17-21-18.webm
And here's how it works with changes from this PR:
Screencast From 2025-06-16 17-22-04.webm