Repository navigation
fix: sleeping HRM no longer blocks Start - #4
Merged
Merged
Conversation
Owner
Author
Review gate: PASS
MINOR findings (0)None. |
Owner
Author
|
Shipped as 933b24a on main. What changes: Start no longer fails with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Since #1 the session builder auto-fills the rider's strap. A strap only advertises once worn, so after an app restart it is not in the hub yet, and `POST /api/sessions` answered `400 Unknown HRM ` (seen live on the first ride after #2).
Fix
Evidence