Defer ast parsing#8
Merged
Merged
Conversation
While on an individual basis, assertions are relatively cheap, it turns out to not be so cheap when you put a whole test suite together. This delays building the error message, and in particular, performing AST parsing, until someone actually attempts to print it. Which means a passing test suite never pays the cost. As future work in this vein, it might also make sense to cache parsed files such that multiple failing calls in the same file don't parse the file multiple times. This includes a breaking change to `ghostlib` to allow lazily evaluating arguments while still being roughly as easy to use.
This moves to a single `FileSet` and one call to `ParseFile` per file. While this does add what should be a pretty small bit of overhead in terms of global state, what this accomplishes is that if more than one assertion needs to print information from the same file, we don't parse the file from disk over and over again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.