Skip to content

refactor(release): stage app into dedicated dir for create-dmg #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinsky merged 1 commit into from
May 15, 2026
Merged

refactor(release): stage app into dedicated dir for create-dmg #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ jobs:
-exportPath "$EXPORT_DIR" \
-exportOptionsPlist build/ExportOptions.plist

# Remove export artifacts that would end up in the DMG
rm -f "$EXPORT_DIR/DistributionSummary.plist" \
"$EXPORT_DIR/ExportOptions.plist" \
"$EXPORT_DIR/Packaging.log"

echo "Architectures:"
lipo -archs "$EXPORT_DIR/$APP_BUNDLE_NAME/Contents/MacOS/$APP_NAME"

Expand All @@ -184,6 +179,14 @@ jobs:
brew install create-dmg
VERSION=${GITHUB_REF_NAME#v}

# Stage ONLY the .app — never point create-dmg at $EXPORT_DIR
# itself, because xcodebuild also drops DistributionSummary.plist,
# ExportOptions.plist and Packaging.log there.
STAGE_DIR="build/dmg-stage"
rm -rf "$STAGE_DIR"
mkdir -p "$STAGE_DIR"
cp -R "$EXPORT_DIR/$APP_BUNDLE_NAME" "$STAGE_DIR/"

create-dmg \
--volname "$APP_NAME" \
--window-pos 200 120 \
Expand All @@ -192,7 +195,7 @@ jobs:
--icon "$APP_BUNDLE_NAME" 175 190 \
--app-drop-link 425 190 \
"build/${DISPLAY_NAME}-${VERSION}.dmg" \
"$EXPORT_DIR/"
"$STAGE_DIR/"

shasum -a 256 "build/${DISPLAY_NAME}-${VERSION}.dmg" | awk '{print $1}' > "build/${DISPLAY_NAME}-${VERSION}.sha256"

Expand Down
Loading