docs(claude): note Sparkle EdDSA key format#10
Conversation
…me back Captures why the SPARKLE_EDDSA_PRIVATE_KEY length check was removed: the secret holds the raw 44-char base64 seed from generate_keys, not a PEM file. sign_update validates by use. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔖 On merge this PR will release v1.3.2 ( |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97ac7290c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Sparkle EdDSA: `SPARKLE_EDDSA_PRIVATE_KEY` secret holds the raw 44-char | ||
| base64 seed exported via Sparkle's `generate_keys`. Do not add a length | ||
| guard — `sign_update` is the source of truth for key validity. |
There was a problem hiding this comment.
This new guidance says the secret should be the raw 44-character seed and that sign_update should be the only validity check, but the local release path documented above still runs release.sh, which rejects any SPARKLE_EDDSA_PRIVATE_KEY shorter than 80 characters before invoking sign_update (release.sh lines 199-203). In the local-release scenario, an agent following this note with the documented 44-character value will still fail before signing; either remove/update that guard or scope this note to the CI workflow that already delegates validation to Sparkle.
Useful? React with 👍 / 👎.
1 participant
Summary
Documents the raw 44-char base64 seed format of
SPARKLE_EDDSA_PRIVATE_KEYso the length-guard regression does not creep back in.Also serves as the release trigger for v1.3.2 — the previous v1.3.1 tag exists but was tagged before the workflow fix, so its
release.ymlrun cannot pick up the corrected validation.Test plan
🤖 Generated with Claude Code