Skip to content

Fix path issues in v1.9.1#172

Open
SanderSander wants to merge 1 commit intormariuzzo:masterfrom
SanderSander:master
Open

Fix path issues in v1.9.1#172
SanderSander wants to merge 1 commit intormariuzzo:masterfrom
SanderSander:master

Conversation

@SanderSander
Copy link
Copy Markdown

Fixes for the paths in v1.9.1

Copy link
Copy Markdown
Owner

@rmariuzzo rmariuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait to double check before merging.

Copy link
Copy Markdown

@Chomiciak Chomiciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ⭐

@SanderSander
Copy link
Copy Markdown
Author

I updated the PR because of the prev commit was reverted (This PR includes those changes).

BTW, I think the original commit adds a feature, so instead releasing it as 1.9.1 a patch version, maybe consider to release it as a minor version 1.10.0

@BaloccoDev
Copy link
Copy Markdown

Any news guys? I'm on Laravel 9 and I had to change the file directly to support the /lang folder instead of /resources/lang

@rmariuzzo
Copy link
Copy Markdown
Owner

I apologize for the slow response. Will chech that today.

@jonaszkadziela
Copy link
Copy Markdown

Hi @rmariuzzo, any idea when this fix will be released? This issue is still causing many headaches for people using Laravel 9, and Laravel 10 is around the corner...

@Chomiciak
Copy link
Copy Markdown

@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.

@jonaszkadziela
Copy link
Copy Markdown

@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.

Looking at the LaravelJsLocalizationServiceProvider class, it still does not locate files in the new default path which is project_root/lang:
https://github.com/rmariuzzo/Laravel-JS-Localization/blob/v1.9.0/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php#L75

Therefore, any fresh Laravel 9.x application or existing project that uses the new path does not work with this package. Running php artisan lang:js -c command leads to the following exception:
LaravelJsLocalization v1-9-0 - LangJsGenerator Exception

So, unfortunately, version 1.9.0 is not working. If this PR is merged, the issue should be resolved.

@rmariuzzo
Copy link
Copy Markdown
Owner

I'm gonna take a look at this today, in a couple of hours.

@thiagorsantoskpmg
Copy link
Copy Markdown

thiagorsantoskpmg commented Feb 10, 2023

Guys, is this fix released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants