fix(android): support RN 0.77 #3749
Conversation
|
@mfazekas since On |
@efstathiosntonas thanks much for looking into it. We can bump and should bump min version to 0.72. |
|
@efstathiosntonas question, have you reread those generated code with 0.77? Or you've modified the code by hand? |
|
Yes, I've modified by hand and tested them on my app while running 0.77. The logs from them linked issue are half way there, if you get past these errors then the errors about |
|
@mfazekas I would like your help in fixing the optional |
|
Any updates on this? I have tried to apply a patch package as mentioned on #3753 (comment) but didn't worked as well. Thx in advance |
same for me |
|
Also blocked by this. Someone actually got the patch to work? Thx! |
I uploaded our patch on the issue that contains the changes from this PR but rebased to the latest published version, along with a Kotlin/AppCompat build error fix: #3753 (comment) It is working for our use case (details in my comment). |
|
I can confirm the patch is working: #3753 (comment) |
|
@efstathiosntonas or @mfazekas Any update for this PR....🙏 |
|
can confirm patch is working as expected. Since rnmapbox doesn't work without this patch, it would make sense to merge this pull request as soon as possible. |
Can you confirm if it works in production? I remember that some guy told that it worked on development build but not in production. |
already using it in production |
This broke my project :( Please merge @efstathiosntonas ty for patch |
|
The patch version for 10.1.38. |
How to install that patch? |
|
@umardev500 - Putting at the patch root RN project directory and running |
My internal testers report that it is working in Production. My device is actually crashing at launch, though. |
Its working perfectly in my production build. |
same thing happening to me |
|
Maybe it's not consistent across devices. Only in a production build (not expo development build), experiencing a consistent crash on some devices, while others do not experience any issues. There seem to be a lot of people in here, across a few different issues and PRs, experiencing this production-only crash. I tried looking at logcat, but it wasn't clear to me what the issue was. |
|
this was fixed in this PR: #3855 Closing |
|
#3855 crashes ios |
|
@zegenerative have you tried/patched this PR and it won’t crash on iOS or you’re just saying generally that it crashes on iOS? |
Sorry was something on my side! Works! |
Description
adds support for react-native@0.77 on Android, iOS builds fine.
LayoutShadowNodewas introduced onrn@0.72.xfixes #3753
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)