Update for React Native 0.78+ Compatibility: Enforce Stricter Kotlin Checks & Migrate to setViewTreeLifecycleOwner API by ShahilMangroliya · Pull Request #3816 · rnmapbox/maps

ShahilMangroliya · 2025-03-28T11:42:26Z

Description

fix(android): support RN 0.78.0+

This PR addresses compatibility with React Native 0.78.0+ by enforcing stricter Kotlin checks, which are required for RN 0.78.0+. These changes ensure the module works reliably with the newer RN versions and prevent potential crashes due to Kotlin mismatch or type-safety issues.

Additionally, this PR updates the usage of ViewTreeLifecycleOwner.set(view, lifecycleOwner); to the newer and preferred API:
view.setViewTreeLifecycleOwner(lifecycleOwner).

Fixes #3815

Checklist

I've read CONTRIBUTING.md
I updated the doc/other generated code with running yarn generate in the root folder
I have tested the new feature on /example app.
- In V11 mode/ios
- In New Architecture mode/ios
- In V11 mode/android
- In New Architecture mode/android
I added/updated a sample - if a new feature was implemented (/example)

… potential crashes

mfazekas

Thanks much for the PR!, can you please add error logging ? So we don't just skip processing when it's null but we log some error. I think non of the changed place is expected to be null

…fecycle management

…s to improve error logging

ShahilMangroliya · 2025-03-29T06:08:19Z

Thanks much for the PR!, can you please add error logging ? So we don't just skip processing when it's null but we log some error. I think non of the changed place is expected to be null

Added Error Logs

…le for improved debugging

mfazekas · 2025-04-05T09:12:21Z

@ShahilMangroliya Can you update the description? Is this PR to prevent crashes? Or to enable building with 0.78.1, which has more strict kotlin checking I assume

…leMap with logging for better debugging

ShahilMangroliya · 2025-04-11T10:17:56Z

@ShahilMangroliya Can you update the description? Is this PR to prevent crashes? Or to enable building with 0.78.1, which has more strict kotlin checking I assume

Updated description

ShahilMangroliya · 2025-04-15T09:10:02Z

@ShahilMangroliya Can you update the description? Is this PR to prevent crashes? Or to enable building with 0.78.1, which has more strict kotlin checking I assume

Done

shahzeb79 · 2025-04-15T10:33:21Z

Can we approve this please?

msaqlain · 2025-04-16T08:30:16Z

@mfazekas Much needed PR. Can we expedite the process, or how can I help?

mfazekas · 2025-04-16T08:32:36Z

 import android.view.View
 import com.facebook.react.bridge.*
-import com.facebook.react.common.MapBuilder
+//import com.facebook.react.common.MapBuilder


pls remove instead of commenting

mfazekas · 2025-04-16T08:35:22Z

                    ReadableType.Boolean -> Expression.literal(expressions.getBoolean(iExp))
                    ReadableType.Number -> Expression.literal(expressions.getDouble(iExp))
-                    else -> Expression.literal(expressions.getString(iExp))
+                    else -> expressions.getString(iExp)?.let { Expression.literal(it) }!!


Can we add a log here as well?

mfazekas · 2025-04-16T08:36:20Z

        when (getType(i)) {
-            ReadableType.Map -> result.add(getMap(i).toJsonObject())
-            ReadableType.Array -> result.add(getArray(i).toJsonArray())
+            ReadableType.Map -> result.add(getMap(i)?.toJsonObject())


pls log here as well

mfazekas · 2025-04-16T11:25:54Z

@ShahilMangroliya pls look into ci failures as well

phosimurg · 2025-05-13T06:30:02Z

@mfazekas @ShahilMangroliya Guys, let's speed up the process please. Too many people are waiting for this.

mfazekas · 2025-05-26T17:52:02Z

See: #3855 it's released as v10.1.39-rc.0

fix(android): add null safety checks in various components to prevent…

3b700ac

… potential crashes

ShahilMangroliya had a problem deploying to CI with Mapbox Tokens March 28, 2025 11:42 — with GitHub Actions Error

mfazekas reviewed Mar 28, 2025

View reviewed changes

Comment thread android/src/main/java/com/rnmapbox/rnmbx/components/images/RNMBXImagesManager.kt

mfazekas reviewed Mar 28, 2025

View reviewed changes

ShahilMangroliya added 2 commits March 29, 2025 11:21

fix(android): set view tree lifecycle owner in RNMBXMapView to fix li…

5956963

…fecycle management

fix(android): enhance null safety checks in image and style component…

5cf6d01

…s to improve error logging

fix(android): add logger import to ChangeLineOffsetsShapeAnimatorModu…

41ed721

…le for improved debugging

ShahilMangroliya had a problem deploying to CI with Mapbox Tokens April 3, 2025 20:13 — with GitHub Actions Error

mfazekas reviewed Apr 5, 2025

View reviewed changes

Comment thread android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXTileSourceManager.kt Outdated

fix(android): improve null value handling in ReadableArray and Readab…

fdc2a25

…leMap with logging for better debugging

ShahilMangroliya temporarily deployed to CI with Mapbox Tokens April 11, 2025 10:17 — with GitHub Actions Inactive

ShahilMangroliya had a problem deploying to CI with Mapbox Tokens April 11, 2025 10:17 — with GitHub Actions Failure

ShahilMangroliya temporarily deployed to CI with Mapbox Tokens April 11, 2025 10:17 — with GitHub Actions Inactive

ShahilMangroliya had a problem deploying to CI with Mapbox Tokens April 11, 2025 10:17 — with GitHub Actions Failure

ShahilMangroliya changed the title ~~fix(android): add null safety checks in various components to prevent…~~ Update for React Native 0.78+ Compatibility: Enforce Stricter Kotlin Checks & Migrate to setViewTreeLifecycleOwner API Apr 11, 2025

mfazekas requested changes Apr 16, 2025

View reviewed changes

Magnus-V mentioned this pull request Apr 25, 2025

Update for React Native 0.78+ Compatibility: Enforce Stricter Kotlin Checks & Migrate to setViewTreeLifecycleOwner API V2 #3844

Closed

7 tasks

mfazekas closed this May 26, 2025

Uh oh!

Conversation

ShahilMangroliya commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

mfazekas left a comment

Choose a reason for hiding this comment

Uh oh!

ShahilMangroliya commented Mar 29, 2025

Uh oh!

Uh oh!

mfazekas commented Apr 5, 2025

Uh oh!

ShahilMangroliya commented Apr 11, 2025

Uh oh!

ShahilMangroliya commented Apr 15, 2025

Uh oh!

shahzeb79 commented Apr 15, 2025

Uh oh!

msaqlain commented Apr 16, 2025

Uh oh!

mfazekas Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

mfazekas Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

mfazekas Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

mfazekas commented Apr 16, 2025

Uh oh!

phosimurg commented May 13, 2025

Uh oh!

mfazekas commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShahilMangroliya commented Mar 28, 2025 •

edited

Loading