Skip to content

Fix(android): Prevent crash in old architecture when updating user location#3838

Merged
mfazekas merged 3 commits into
rnmapbox:mainfrom
Elter71:fix/crash-when-location-update-on-old-arch-android
Jul 26, 2025
Merged

Fix(android): Prevent crash in old architecture when updating user location#3838
mfazekas merged 3 commits into
rnmapbox:mainfrom
Elter71:fix/crash-when-location-update-on-old-arch-android

Conversation

@Elter71

@Elter71 Elter71 commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes 3796

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 15, 2025 09:27 — with GitHub Actions Inactive
mfazekas
mfazekas approved these changes Apr 18, 2025
View reviewed changes

@mfazekas mfazekas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Amazing thanks much for looking into it

mfazekas
mfazekas reviewed Apr 18, 2025
View reviewed changes
Comment thread android/src/main/old-arch/com/rnmapbox/rnmbx/NativeRNMBXLocationModuleSpec.java Outdated
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Inactive
@Elter71 Elter71 had a problem deploying to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Failure
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Inactive
@Elter71 Elter71 temporarily deployed to CI with Mapbox Tokens April 18, 2025 11:25 — with GitHub Actions Inactive
@Elter71

Elter71 commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

Hi @mfazekas,
Could we rerun the pipelines so we can proceed with merging this PR? Thanks!

@notrly

notrly commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

@Elter71 @mfazekas this is still an issue, could you merge this one please?

mfazekas
mfazekas reviewed Jul 9, 2025
View reviewed changes
Comment thread android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt Outdated
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas temporarily deployed to CI with Mapbox Tokens July 9, 2025 17:35 — with GitHub Actions Inactive
@mfazekas mfazekas merged commit 5af2dce into rnmapbox:main Jul 26, 2025
10 of 11 checks passed
efstathiosntonas pushed a commit to efstathiosntonas/maps that referenced this pull request Aug 8, 2025
@Elter71 @mfazekas @efstathiosntonas
Fix(android): Prevent crash in old architecture when updating user lo…
5d51973 
…cation (rnmapbox#3838)

* fix(android): prevent crash in old architecture when updating user location

* fix(android): move update location callback from auto generated code

* Update android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt

---------

Co-authored-by: Miklós Fazekas <mfazekas@szemafor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfazekas mfazekas mfazekas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Usage of UserLocation causes app crash on Android when new arch is disabled

3 participants

@Elter71 @notrly @mfazekas