Skip to content

Fixed Issue : #3756 ( Mapbox [error] ViewTagResolver) #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Med-Li-Jr wants to merge 1 commit into from
Closed

Fixed Issue : #3756 ( Mapbox [error] ViewTagResolver) #3852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/MapView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,6 +1171,14 @@ class MapView extends NativeBridgeComponent(
}
}

if (mapView == null) {

@mfazekas mfazekas May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is good way to solve the issue.
mapView will be null if on layout has not been called yet.

Can't we just add an else to set mapView to an empty fragment instead of null?

if (this.state.isReady) {
  ...
} else {
  mapView = <></>
}

@LukasB-DEV LukasB-DEV May 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Med-Li-Jr code works. @mfazekas your suggestion does not work

@Med-Li-Jr Med-Li-Jr May 6, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfazekas, yeah me too, I didn't think it was a good way to solve it, but it was the only one amongs the things I tried that solved it on my side, I tried the following, but other errors appeared :

  • Attemp 1 :

       let mapView = {} as NativeMapViewActual;
   if (this.state.isReady) {
      ...
    }

  • Attemp 2 :

        let mapView = <RNMBXMapView> </RNMBXMapView>;
    if (this.state.isReady) {
      ...
    }

  • Attemp 3 :

        let mapView = <></>;
    if (this.state.isReady) {
      ...
    }

  • etc....

@Med-Li-Jr Med-Li-Jr May 6, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasB-DEV, I see, then just changed it on your local code, maybe later, there will be an update that will fix it.

@mfazekas mfazekas May 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Med-Li-Jr is there a code to reproduce the issue? It's not clear in #3756 how to reproduce the issue

@shahzeb79 shahzeb79 May 23, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it dont catches everything. Many times same error also comes, but less frequent

@LukasB-DEV LukasB-DEV May 23, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Med-Li-Jr can you reacheck this?

@Med-Li-Jr Med-Li-Jr May 25, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahzeb79 , @LukasB-DEV I tried with the init code I don't see the error, Can you share the part of your code that gives the errors ?

@shahzeb79 shahzeb79 May 25, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Med-Li-Jr i face error when lets say i click on icon on map, or state changes on mapscreen. error get triggered but its also random

@Med-Li-Jr Med-Li-Jr May 26, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahzeb79 I see, so that means it's probably a deep error in the project, it may be coming from another file, we'll have to wait for an official resolution😕

mapView = (
<RNMBXMapView {...props} {...callbacks}>
{this.props.children}
</RNMBXMapView>
)
}

return (
<View
onLayout={this._onLayout}
Expand Down
Loading