Skip to content

fix(ios): support 'url' prop for ShapeSource on iOS#3866

Closed
HarshaZeitview wants to merge 1 commit into
rnmapbox:mainfrom
HarshaZeitview:fix/shapesource-url-support-ios
Closed

fix(ios): support 'url' prop for ShapeSource on iOS#3866
HarshaZeitview wants to merge 1 commit into
rnmapbox:mainfrom
HarshaZeitview:fix/shapesource-url-support-ios

Conversation

@HarshaZeitview

Copy link
Copy Markdown
Contributor

Description

support 'url' prop for ShapeSource on iOS

Fixes #3863

Added your feature that allows ...

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Minimal fix, tested in own app (Android / iOS)

@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@HarshaZeitview HarshaZeitview had a problem deploying to CI with Mapbox Tokens June 4, 2025 08:53 — with GitHub Actions Failure
@mfazekas

mfazekas commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

@HarshaZeitview can you rebase to current main, so CI can be running?

@HarshaZeitview

HarshaZeitview commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

Hi @mfazekas so now i need to rebase to current main ? and how to check CI is running or not ?

@HarshaZeitview

Copy link
Copy Markdown
Contributor Author

Hi @mfazekas any update on this please!

@ljukas

ljukas commented Sep 9, 2025

Copy link
Copy Markdown

This is still a problem where a patch is required. Would be great if this could be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to display layers using ShapeSource with it's URL prop

3 participants