fix(android): ignore camera padding for marker view#3888
Conversation
2a2d20e to
49bc97f
Compare
|
@ghitier thanks much, is this Mapbox 11 only? For now we'll need to add some shim that's a noop on Mapbox 10, if that doesn't supports it. file:///home/runner/work/maps/maps/android/src/main/java/com/rnmapbox/rnmbx/components/annotation/RNMBXMarkerView.kt:189:13 Unresolved reference 'ignoreCameraPadding'. |
|
Hi @mfazekas. Thanks for getting back to me on this PR. Yes, actually this fix is only for Mapbox v11. I didn't realise the I did take a quick look today: If I understand right I should add some sort of function in Anyways, I will try to take a look. EDIT 1 : I just realised I can do the exact same as for EDIT 2 : Should be fixed now ✅ |
800eed4 to
66e3a58
Compare
* fix(android): ignore camera padding for marker view * fix(android): mapbox 10 build error (due to cameraIgnorePadding option)
Description
Fixes #3887
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
See demo GIFs in #3887. Android now behaves the same as iOS (marker views don't disappear anymore).
Component to reproduce the issue you're fixing
See demo code in #3887.