Fix #3889 : With react new arch, allowOverlap is always true#3890
Merged
Conversation
This bug appears using the new react architecture. This is because of the id allowOverlap = RNMBXConvertFollyDynamicToId(newProps.allowOverlap); conversions that returns a pointer that is always true instead of the value of the pointed object according to rnmapbox#3730
mfazekas
approved these changes
Jul 3, 2025
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
scharron
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
efstathiosntonas
pushed a commit
to efstathiosntonas/maps
that referenced
this pull request
Aug 8, 2025
…nmapbox#3890) This bug appears using the new react architecture. This is because of the id allowOverlap = RNMBXConvertFollyDynamicToId(newProps.allowOverlap); conversions that returns a pointer that is always true instead of the value of the pointed object according to rnmapbox#3730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug appears using the new react architecture. This is because of the id allowOverlap = RNMBXConvertFollyDynamicToId(newProps.allowOverlap); conversions that returns a pointer that is always true instead of the value of the pointed object according to #3730
Description
Fixes #3889
This bug appears using the new react architecture. This is because of the id allowOverlap = RNMBXConvertFollyDynamicToId(newProps.allowOverlap); conversions that returns a pointer that is always true instead of the value of the pointed object according to #3730
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing