Skip to content

Fix #3780 (iOS): Update lineMetrics type from NSNumber to Bool #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfazekas merged 2 commits into from
Jul 28, 2025
Merged

Fix #3780 (iOS): Update lineMetrics type from NSNumber to Bool #3905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbaa620
Update lineMetrics type from NSNumber to Bool
john-trieu-nguyen Jul 17, 2025
ebdae9b
Merge branch 'main' into fix/line-metrics-type
john-trieu-nguyen Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ios/RNMBX/RNMBXShapeSource.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public class RNMBXShapeSource : RNMBXSource {
@objc public var maxZoomLevel : NSNumber?
@objc public var buffer : NSNumber?
@objc public var tolerance : NSNumber?
@objc public var lineMetrics : NSNumber?
@objc public var lineMetrics : Bool = false

override func sourceType() -> Source.Type {
return GeoJSONSource.self
Expand Down Expand Up @@ -147,9 +147,7 @@ public class RNMBXShapeSource : RNMBXSource {
result.tolerance = tolerance.doubleValue
}

if let lineMetrics = lineMetrics {
result.lineMetrics = lineMetrics.boolValue
}
result.lineMetrics = lineMetrics

return result
}
Expand Down
2 changes: 1 addition & 1 deletion ios/RNMBX/RNMBXShapeSourceComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
RNMBX_OPTIONAL_PROP_NSNumber(maxZoomLevel)
RNMBX_OPTIONAL_PROP_NSNumber(buffer)
RNMBX_OPTIONAL_PROP_NSNumber(tolerance)
RNMBX_OPTIONAL_PROP_NSNumber(lineMetrics)
RNMBX_OPTIONAL_PROP_BOOL(lineMetrics)
RNMBX_OPTIONAL_PROP_BOOL(hasPressListener)
RNMBX_OPTIONAL_PROP_NSDictionary(hitbox)

Expand Down
2 changes: 1 addition & 1 deletion ios/RNMBX/RNMBXShapeSourceViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
RCT_EXPORT_VIEW_PROPERTY(maxZoomLevel, NSNumber)
RCT_EXPORT_VIEW_PROPERTY(buffer, NSNumber)
RCT_EXPORT_VIEW_PROPERTY(tolerance, NSNumber)
RCT_EXPORT_VIEW_PROPERTY(lineMetrics, NSNumber)
RCT_EXPORT_VIEW_PROPERTY(lineMetrics, BOOL)
RCT_EXPORT_VIEW_PROPERTY(images, NSDictionary)
RCT_EXPORT_VIEW_PROPERTY(nativeImages, NSArray)
RCT_EXPORT_VIEW_PROPERTY(hasPressListener, BOOL)
Expand Down
Loading