New Architecture Enabled fix for getLastKnownLocation iOS method and Fixing cloneReactChildrenWithProps in Javascript Module#3923
Merged
mfazekas merged 1 commit intoAug 11, 2025
Conversation
…here the children property contains a child which is a React.Fragment, for which no prop can be added. toJSON method always returns a [String:Any] dictionary, hence there is no need to have the value type to be "Any?" getLastKnownLocation now returns an optional [String:Any] value, which is compliant with objective-c, in place of the RNMBXLocation type.
Closed
mfazekas
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the cloneReactChildrenWithProps method to handle those cases where the children property contains a child which is a React.Fragment, for which no prop can be added.
getLastKnownLocationfor when New Architecture is enabled now returns an optional[String:Any]?value, which is compliant with Objective-C, in place of theRNMBXLocationtype. This change is needed for the javascript invocation to actually work, when building the app with New Architecture enabled.toJSONiOS method for builds with New Architecture enabled always returns a[String:Any]dictionary, hence there is no need for the dictionary value type to beAny?Description
Fixes an issue that prevented the proper retrieval of last known location when using New Architecture on iOS. In addition to that, another fix has been implemented to make sure that the
cloneReactChildrenWithPropsmethod handles properly those cases where thechildrenproperty contains a child which is aReact.Fragment, for which no prop can be added, and therefore should not be added, otherwise a crash would happen.Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Component to reproduce the issue you're fixing
Since it's just a few lines change, thanks to which my app is not crashing anymore, I am omitting the test component in this description.