Skip to content

Update hasNoDataSoRefersToExisting logic for RNMBXRasterSource#4205

Merged
mfazekas merged 1 commit into
rnmapbox:mainfrom
scharron:patch-2
May 24, 2026
Merged

Update hasNoDataSoRefersToExisting logic for RNMBXRasterSource#4205
mfazekas merged 1 commit into
rnmapbox:mainfrom
scharron:patch-2

Conversation

@scharron

Copy link
Copy Markdown
Contributor

Description

Raster doesn't work on Android.
RNMBXRasterSource now uses tileUrlTemplates instead of uRL, and therefore it should check it contains data to render.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reproduce the issue you're fixing

RNMBXRasterSource now uses tileUrlTemplates instead of uRL, and should check it contains data to render.
Copilot AI review requested due to automatic review settings May 15, 2026 22:02
@scharron scharron temporarily deployed to CI with Mapbox Tokens May 15, 2026 22:02 — with GitHub Actions Inactive
@scharron scharron temporarily deployed to CI with Mapbox Tokens May 15, 2026 22:02 — with GitHub Actions Inactive
@scharron scharron deployed to CI with Mapbox Tokens May 15, 2026 22:02 — with GitHub Actions Active
@mfazekas mfazekas merged commit ab2a6dc into rnmapbox:main May 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants