Add control-plane direct shell commands#150
Conversation
20c918b to
152c68e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 152c68e5c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onError: (error: unknown) => { | ||
| const message = error instanceof Error ? error.message : String(error); | ||
| this.createEngine(args).sessions.appendMessage(args.sessionId, { | ||
| id: `direct-shell-error-${Date.now()}`, | ||
| role: 'assistant', | ||
| text: `Direct shell execution failed:\n${message}`, | ||
| }); | ||
| }, |
There was a problem hiding this comment.
Drain queued prompts after direct shell runs
When a direct shell run is accepted while the session already has queued prompts (for example, a user sends !cmd after a turn finishes but before the queued-drain starts, or any session has queued prompts with no in-flight run), this run never restarts the queue after it settles. buildSubmitPromptRun wires onSettled to startNextQueuedPrompt, but this direct-shell run object only defines execute/onError, so the queued prompts can remain stuck until another normal prompt submission happens to trigger the drain.
Useful? React with 👍 / 👎.
152c68e to
f91b562
Compare
Summary
Validation