Skip to content

Add control-plane direct shell commands#150

Merged
roackb2 merged 1 commit into
mainfrom
codex/direct-shell-control-plane
Jun 1, 2026
Merged

Add control-plane direct shell commands#150
roackb2 merged 1 commit into
mainfrom
codex/direct-shell-control-plane

Conversation

@roackb2
Copy link
Copy Markdown
Owner

@roackb2 roackb2 commented Jun 1, 2026

Summary

  • add a core chat direct-shell service for shared !command semantics over shell-process policy
  • expose controlPlane.sessionDirectShellAsync and route cli-v2/web-v2 through it
  • add direct-shell live activities, shared prompt parsing, and regression coverage

Validation

  • yarn typecheck
  • yarn test src/tests/unit/client-shared/prompt-input-service.test.ts src/tests/unit/client-shared/session-activity-service.test.ts src/tests/unit/cli-v2/control-plane-session-store.test.ts src/tests/integration/control-plane/session-lifecycle.test.ts
  • yarn build

@roackb2 roackb2 force-pushed the codex/direct-shell-control-plane branch 2 times, most recently from 20c918b to 152c68e Compare June 1, 2026 13:44
@roackb2 roackb2 marked this pull request as ready for review June 1, 2026 13:47
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 152c68e5c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +607 to +614
onError: (error: unknown) => {
const message = error instanceof Error ? error.message : String(error);
this.createEngine(args).sessions.appendMessage(args.sessionId, {
id: `direct-shell-error-${Date.now()}`,
role: 'assistant',
text: `Direct shell execution failed:\n${message}`,
});
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Drain queued prompts after direct shell runs

When a direct shell run is accepted while the session already has queued prompts (for example, a user sends !cmd after a turn finishes but before the queued-drain starts, or any session has queued prompts with no in-flight run), this run never restarts the queue after it settles. buildSubmitPromptRun wires onSettled to startNextQueuedPrompt, but this direct-shell run object only defines execute/onError, so the queued prompts can remain stuck until another normal prompt submission happens to trigger the drain.

Useful? React with 👍 / 👎.

@roackb2 roackb2 force-pushed the codex/direct-shell-control-plane branch from 152c68e to f91b562 Compare June 1, 2026 13:58
@roackb2 roackb2 merged commit 4905ea0 into main Jun 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant