Skip to content

Refactor cli-v2 session store workflows#151

Merged
roackb2 merged 1 commit into
mainfrom
codex/cli-v2-store-decomposition
Jun 1, 2026
Merged

Refactor cli-v2 session store workflows#151
roackb2 merged 1 commit into
mainfrom
codex/cli-v2-store-decomposition

Conversation

@roackb2
Copy link
Copy Markdown
Owner

@roackb2 roackb2 commented Jun 1, 2026

Summary

  • split the cli-v2 control-plane session store into a small facade plus focused workflow owners for snapshot state, loading, prompt routing, slash commands, direct shell, approvals, run polling, and live events
  • removed private one-line forwarding wrappers from the store facade; callback wiring now points at the owning service/controller directly
  • documented the state-layer ownership rules and no-thin-wrapper invariants
  • preserved the existing public store API used by Ink components while keeping domain policy in control-plane/client-shared/core owners

Tests

  • yarn typecheck
  • yarn test src/tests/unit/cli-v2/control-plane-session-store.test.ts src/tests/unit/cli-v2/prompt-activity.test.ts src/tests/unit/cli-v2/runtime-status.test.ts src/tests/unit/cli-v2/file-mention-picker.test.tsx
  • yarn build
  • rg -n "from '"|from ['"].*(core|server|cli/chat)" src/cli-v2
  • rg -n "runShellCommand|shell-process|ConversationDirectShellService|ToolApprovalService" src/cli-v2 src/web-v2

Manual regression surface

  • cli-v2 startup, workspace/session loading, and switching sessions
  • normal prompt submit, queued prompt submit during active run, and assistant stream rendering
  • slash command execution, command result retention, and command-driven session switching/continue
  • direct shell preflight, confirmation/cancel/run, and direct shell result activity
  • pending approval refresh/resolution, run cancellation, and polling recovery when live events lag
  • plan/current activity/latest activity rendering, runtime status bar, and file mention search

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@roackb2 roackb2 force-pushed the codex/cli-v2-store-decomposition branch from 0652000 to cf5decf Compare June 1, 2026 16:09
@roackb2 roackb2 merged commit 0c68cb4 into main Jun 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant