Skip to content

[codex] Switch default chat to TUI v2#155

Merged
roackb2 merged 1 commit into
mainfrom
codex/tui-v2-default-chat
Jun 2, 2026
Merged

[codex] Switch default chat to TUI v2#155
roackb2 merged 1 commit into
mainfrom
codex/tui-v2-default-chat

Conversation

@roackb2
Copy link
Copy Markdown
Owner

@roackb2 roackb2 commented Jun 2, 2026

Summary

  • route bare heddle and heddle chat to the API-backed TUI v2 command path
  • add heddle chat-v1 plus dev script variants as the explicit legacy TUI escape hatch
  • update focused docs and routing coverage for the default-chat cutover

Expected behavior change

  • normal interactive chat now starts TUI v2 and can attach/embed the shared control-plane server
  • legacy TUI remains available through chat-v1 and chat:dev:v1
  • non-chat commands are unchanged

Verification

  • yarn -s vitest run src/__tests__/unit/cli/main-command-routing.test.ts
  • yarn typecheck
  • yarn lint
  • yarn test:unit
  • yarn -s cli:dev --help

@roackb2 roackb2 marked this pull request as ready for review June 2, 2026 08:48
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df34b7d3d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/cli/main.ts
const resolved = resolveCliOptions(program.opts<RootCliOptions>());
chdir(resolved.workspaceRoot);
writeRuntimeHostNotice('chat', resolved.runtimeHost);
await runChatCliV2Command(resolved);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid attaching default chat to another embedded TUI

When heddle chat now delegates to runChatCliV2Command, it inherits resolveChatV2Runtime's attach-to-any-fresh-server behavior, including a live server whose registry mode is embedded-chat. In that scenario the backend is owned by another terminal chat and runtime.close is a no-op for this client, so if the original TUI exits this default chat loses its control-plane server and subsequent requests fail; attaching is safe for daemon mode, but default chat should start its own embedded server or only attach to daemon-owned servers.

Useful? React with 👍 / 👎.

@roackb2 roackb2 force-pushed the codex/tui-v2-default-chat branch from 80861ad to dd58e98 Compare June 2, 2026 09:34
@roackb2 roackb2 merged commit f666496 into main Jun 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant