[codex] Switch default chat to TUI v2#155
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df34b7d3d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const resolved = resolveCliOptions(program.opts<RootCliOptions>()); | ||
| chdir(resolved.workspaceRoot); | ||
| writeRuntimeHostNotice('chat', resolved.runtimeHost); | ||
| await runChatCliV2Command(resolved); |
There was a problem hiding this comment.
Avoid attaching default chat to another embedded TUI
When heddle chat now delegates to runChatCliV2Command, it inherits resolveChatV2Runtime's attach-to-any-fresh-server behavior, including a live server whose registry mode is embedded-chat. In that scenario the backend is owned by another terminal chat and runtime.close is a no-op for this client, so if the original TUI exits this default chat loses its control-plane server and subsequent requests fail; attaching is safe for daemon mode, but default chat should start its own embedded server or only attach to daemon-owned servers.
Useful? React with 👍 / 👎.
80861ad to
dd58e98
Compare
Summary
heddleandheddle chatto the API-backed TUI v2 command pathheddle chat-v1plus dev script variants as the explicit legacy TUI escape hatchExpected behavior change
chat-v1andchat:dev:v1Verification
yarn -s vitest run src/__tests__/unit/cli/main-command-routing.test.tsyarn typecheckyarn lintyarn test:unityarn -s cli:dev --help