revert: serve resetter RPC over goridge net/rpc, keep the new API

[rustatian]

Part of the org-wide Connect-RPC revert: the RPC surface returns to net/rpc over the goridge codec while keeping the new api-go message set and method names. Connect handlers were converted in place, connect-only API tests removed, and api-go/goridge/rpc are pinned to the revert branches (pseudo-versions to be replaced by tags).

[Copilot]

Pull request overview

Reverts the resetter RPC transport from Connect-RPC back to net/rpc served via the goridge codec, while keeping the newer api-go message types and method naming.

Changes:

• Replaced Connect-RPC handler implementation with net/rpc-style service methods (Reset, ListPlugins) in rpc.go.
• Updated plugin RPC exposure to return a goridge/netrpc service object instead of an HTTP handler.
• Simplified tests by removing Connect/HTTP/gRPC surface tests and switching the remaining RPC test to a goridge net/rpc client.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/resetter_test.go	Switches RPC test client from Connect over HTTP/2 to net/rpc over goridge.
tests/resetter_api_test.go	Removes Connect/HTTP/gRPC wire-surface tests for the revert.
tests/go.mod	Drops Connect/grpc-related deps and pins revert pseudo-versions for api-go/goridge/rpc.
tests/go.sum	Updates checksums to match dependency removals and pinned pseudo-versions.
tests/.rr-resetter-api.yaml	Removes config used only by the deleted API surface tests.
rpc.go	Converts resetter RPC methods from Connect handlers to net/rpc method signatures.
plugin.go	Changes RPC() to return the net/rpc service instance (for goridge).
go.sum	Removes Connect/grpc-related sums and pins api-go pseudo-version.
go.mod	Removes Connect dependency and pins api-go pseudo-version.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Warning

Review limit reached

@rustatian, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 867b0bed-b5f5-45d9-941a-a24d1a58744e

📥 Commits

Reviewing files that changed from the base of the PR and between 445a77f and 21b9cd2.

⛔ Files ignored due to path filters (2)

• go.sum is excluded by !**/*.sum
• tests/go.sum is excluded by !**/*.sum

📒 Files selected for processing (7)

• go.mod
• plugin.go
• rpc.go
• tests/.rr-resetter-api.yaml
• tests/go.mod
• tests/resetter_api_test.go
• tests/resetter_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert/connectrpc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.00%. Comparing base (445a77f) to head (21b9cd2).

Files with missing lines	Patch %	Lines
rpc.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   83.33%   92.00%   +8.66%     
==========================================
  Files           2        2              
  Lines          24       25       +1     
==========================================
+ Hits           20       23       +3     
+ Misses          2        1       -1     
+ Partials        2        1       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.