Converted Chronic to a portable library - #5
Open
eugenpodaru wants to merge 3 commits into
Open
eugenpodaru wants to merge 3 commits into
eugenpodaru wants to merge 3 commits into
Conversation
Owner
|
Thanks for the PR Eugene - I will try to find some time and think how to best integrate your changes and still keep the regex compilation (will test if it has any real benefits). Maybe a second, portable, nuget will be the way to go. |
Author
|
Here you can find an article about RegexOptions.Compiled http://blog.codinghorror.com/to-compile-or-not-to-compile/. The only scenario where it may count is when you have a lot of expressions to parse in a loop, which is a valid scenario. So maybe it would be better to have two versions. I leave this to you to decide. For now I use the modified library from a private repository, but if you decide to put it on nuget, i will use the official one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've converted Chronic to a portable library.
To make it compile I had to remove the RegexOptions.Compiled flag used when creating regular expressions as it is not supported in SL and WP.
I also changed Math.Truncate with Math.Floor in two places as Math.Truncate is missing from SL and WP. Floor and Truncate behave in the same way for positive numbers, which was the case in those two places.
I want to use the library in a SL project, so that's why I did this. If you accept the pull request, and push it to nuget, I will get it from there. Otherwise I will just use the binaries compiled from my branch.
Regards,
Eugen