Conversation
Given that all of the arrays except for BIG_PREFIXES use the English names for numbers, I realize that this library is intended to be used for English language applications. MOST English speaking locales use short scale where billion means 10^9. However, there are some locales that use long scale where billion means 10^12 and 10^9 is represented by the word milliard (and 10^15 is billion instead of trillion). https://en.wikipedia.org/wiki/Long_and_short_scales
See comment on Numerizer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robert,
Your profile (and your last name 😄) says you are from Poland so I realize you are aware of milliard, billiard, etc. (long scale.) I also realize that this library is obviously targeted at English speaking locales since the words in the arrays in the Numerizer class are English (one, two, three,...) Since there are extremely limited usages of long scale in English today you may not want to accept this pull request but I thought I would put it out there just in case.