#1962 fix cascading locators #1963
Open
+115
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed a couple incorrectly modified type hints on click button and click image - Added type hints to get webelement(s) keywords
yuriverweij
requested changes
Jan 19, 2026
Member
yuriverweij
left a comment
yuriverweij
left a comment
There was a problem hiding this comment.
We're already importing typing, so this could be simplified for us.
from typing import TypeAlias
from selenium.webdriver.remote.webelement import WebElement
Locator: TypeAlias = WebElement | str | list["Locator"]
The we can use
locator: Locator
Member
Author
|
Rethinking what you are saying Yuri and see your point. Thinking we could make that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1962 chaining or cascading locators has been broken for a while. This PR addresses the problem.