Be sure that when we close/halt, we wake-up all tasks without effects - #28
Merged
Merged
Conversation
This patch is a fix about close/halt and ensure: 1) when we close/halt, we wake up **all** pending tasks on put/get. We can see this fix as a replacement of Miou.Condition.signal to Miou.Condition.broadcast 2) be sure that close/halt don't emit effects and are usable inside a finally function (into a Miou.Ownership resource, for instance). For that point, we re-implemented a poor-man Miou.Condition with Miou.Trigger and ensure that we don't need to Miou.protect (which can emit an effect with its internal [Trigger.await]) when we would like to wakeup all pending tasks
raphael-proust
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Sep 21, 2026
CHANGES: - Our `Flux.Bqueue.close` is atomic (in the point of view of Miou) (@dinosaure, robur-coop/flux#28, robur-coop/flux#29)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is a fix about close/halt and ensure:
can see this fix as a replacement of Miou.Condition.signal to
Miou.Condition.broadcast
finally function (into a Miou.Ownership resource, for instance). For
that point, we re-implemented a poor-man Miou.Condition with
Miou.Trigger and ensure that we don't need to Miou.protect (which can
emit an effect with its internal [Trigger.await]) when we would like
to wakeup all pending tasks