Tests for unikernel endpoints - #291
Merged
Merged
Conversation
Contributor
|
I squash-merged #286, this now needs to be rebased.. |
PizieDust
force-pushed
the
unikernel_endpoints
branch
from
September 22, 2026 14:40
da6001a to
22372d6
Compare
hannesm
reviewed
Sep 22, 2026
Comment on lines
+523
to
555
| let auth_hdr = | ||
| match token with | ||
| | Some t -> Fmt.str "Authorization: Bearer %s\r\n" t | ||
| | None -> "" | ||
| in | ||
| let cookie_hdr = | ||
| match (session_cookie, csrf_token) with | ||
| | "", "" -> "" | ||
| | s, "" -> Fmt.str "Cookie: molly_session=%s\r\n" s | ||
| | "", c -> Fmt.str "Cookie: molly_csrf=%s\r\n" c | ||
| | s, c -> Fmt.str "Cookie: molly_session=%s; molly_csrf=%s\r\n" s c | ||
| in | ||
| Fmt.str | ||
| "GET %s HTTP/1.1\r\n\ | ||
| Host: localhost\r\n\ | ||
| User-Agent: Alcotest-client\r\n\ | ||
| %s%s\r\n" | ||
| path auth_hdr cookie_hdr | ||
|
|
||
| let make_post_request ~path ~body ?(csrf_token = "") ?(session_cookie = "") | ||
| ?token () = | ||
| let auth_hdr = | ||
| match token with | ||
| | Some t -> Fmt.str "Authorization: Bearer %s\r\n" t | ||
| | None -> "" | ||
| in | ||
| let cookie_hdr = | ||
| match (session_cookie, csrf_token) with | ||
| | "", "" -> "" | ||
| | s, "" -> Fmt.str "Cookie: molly_session=%s\r\n" s | ||
| | "", c -> Fmt.str "Cookie: molly_csrf=%s\r\n" c | ||
| | s, c -> Fmt.str "Cookie: molly_session=%s; molly_csrf=%s\r\n" s c | ||
| in |
Contributor
There was a problem hiding this comment.
there's room for refactoring here...
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for unikernel endpoints.
GET /api/unikernelsPOST /api/unikernel/createPOST /api/unikernel/destroyPOST /api/unikernel/restart