Search: allow typos when searching by string#20660
Open
SkySkimmer wants to merge 1 commit into
Open
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Contributor
|
How about ⌊(n + 4) / 8⌋ (0 when <= 4, then +1 every 8 characters in length) ? |
Contributor
Author
|
That's the same as |
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Contributor
It would need to round 0.5 down, but except for that yes. My suggestion was also meant to be implemented as |
coqbot-app
Bot
added
the
needs: full CI
SkySkimmer
force-pushed
the
search-fuzzy
branch
from
8e8d3ee to
2851a2d
Compare
github-actions
Bot
added
the
needs: rebase
coqbot-app
Bot
removed
the
needs: rebase
ppedrot
reviewed
May 5, 2026
|
|
||
| let name_of_reference ref = Id.to_string (Nametab.basename_of_global ref) | ||
|
|
||
| let string_contains_upto ?(limit=2) ~pattern s = |
Member
There was a problem hiding this comment.
Please add an option to set (optionally) the maximum distance allowed.
SkySkimmer
added
needs: progress
coqbot-app
Bot
removed
request: full CI
SkySkimmer
added
the
request: full CI
For experimentation I set to to require exact substring match when the searched string has length <= 4, and allow edit distance <= 2 otherwise. These 2 numbers could be turned into user-settable options. IDK if these are good defaults. Also not sure if constant ints is the right way to work. eg with longer input strings we may want to allow more typos so maybe `2` should be `min 2 (2% of input string length)` or some such thing. Probably needs user feedback to progress. (also no idea how performant this is)
coqbot-app
Bot
removed
the
request: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For experimentation I set to to require exact substring match when the searched string has length <= 4, and allow edit distance <= 2 otherwise. These 2 numbers could be turned into user-settable options.
IDK if these are good defaults.
Also not sure if constant ints is the right way to work. eg with longer input strings we may want to allow more typos so maybe
2should bemin 2 (2% of input string length)or some such thing.Probably needs user feedback to progress.
(also no idea how performant this is)