Ltac2 local env APIs#21654
Open
SkySkimmer wants to merge 8 commits into
Open
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
added
kind: feature
SkySkimmer
added
needs: changelog entry
SkySkimmer
force-pushed
the
ltac2-ctx
branch
from
5d25632 to
52d367c
Compare
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
ltac2-ctx
branch
from
52d367c to
73325e3
Compare
coqbot-app
Bot
removed
the
request: full CI
github-actions
Bot
added
the
needs: rebase
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
ltac2-ctx
branch
from
73325e3 to
e09aa88
Compare
coqbot-app
Bot
removed
request: full CI
Contributor
|
Should these new APIs be documented in the Ltac2 chapter or are they too internal? |
Contributor
|
@cpitclaudel to me its part of the corelib for Ltac2, it does not need any further documentation. One can write a tutorial or how-to for Platform Docs, if the they want to discuss how to use them |
github-actions
Bot
added
the
needs: rebase
SkySkimmer
force-pushed
the
ltac2-ctx
branch
2 times, most recently
from
f071bf4 to
fe3a440
Compare
coqbot-app
Bot
added
needs: full CI
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
request: full CI
Contributor
Author
|
changed to use result instead of backtracking exceptions |
github-actions
Bot
added
the
needs: rebase
coqbot-app
Bot
added
needs: full CI
1 task
JasonGross
reviewed
May 26, 2026
Comment on lines
+402
to
+403
| Ltac2 @external eval_in_env : env -> Std.Red.t -> constr -> constr | ||
| := "rocq-runtime.plugins.ltac2" "reduce_constr_in_env". |
Member
There was a problem hiding this comment.
Shouldn't we route Ltac2 eval through this function?
Contributor
Author
There was a problem hiding this comment.
what are you calling Ltac2 eval?
JasonGross
reviewed
May 26, 2026
| Ltac2 Type t := sort. | ||
|
|
||
| (** [sort_of_product s s'] is [s''] such that if [A : s] and [B : s'] then [A -> B : s'']. *) | ||
| Ltac2 @external sort_of_product : t -> t -> t |
Member
There was a problem hiding this comment.
Are we sure we want Sort.sort_of_product rather than Sort.of_product?
JasonGross
reviewed
May 26, 2026
|
|
||
| Module UnsafeEnv. | ||
| (** Print the given term in the given environment (does not print the environment). *) | ||
| Ltac2 @external message_of_constr_in_env : env -> constr -> message |
Member
There was a problem hiding this comment.
This should presumably be of_constr_in_env to match with all of the other names here. And plausibly we should route of_constr through this function
JasonGross
reviewed
May 26, 2026
Comment on lines
+43
to
+46
| (** Early declaration, see [Relevance.UnsafeEnv]. *) | ||
| Local Ltac2 @external relevance_of_type_in_env : env -> constr -> relevance | ||
| := "rocq-runtime.plugins.ltac2" "relevance_of_type_in_env". | ||
|
|
Member
There was a problem hiding this comment.
Can't we just move Module Relevance up and do Ltac2 Type relevance := Relevance.t instead of the other way around
Contributor
Author
There was a problem hiding this comment.
we have Ltac2 Import Type so we could use that to avoid breaking references to Binder.Relevant
not sure I want to do it in this PR
JasonGross
reviewed
May 27, 2026
Co-authored-by: Jason Gross <jasongross9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return of #20206, now with unsafe APIs marked unsafe