Move the dubious compare and hash functions from Constr to a Termops submodule#21863
Merged
coqbot-app[bot] merged 2 commits intoApr 1, 2026
Merged
Conversation
ppedrot
added
kind: cleanup
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
approved these changes
Apr 1, 2026
ppedrot
added a commit
to ppedrot/aac-tactics
that referenced
this pull request
Apr 1, 2026
ppedrot
added a commit
to ppedrot/equations
that referenced
this pull request
Apr 1, 2026
ppedrot
added a commit
to ppedrot/Mtac2
that referenced
this pull request
Apr 1, 2026
ppedrot
added a commit
to ppedrot/smtcoq
that referenced
this pull request
Apr 1, 2026
ppedrot
added a commit
to ppedrot/stalmarck
that referenced
this pull request
Apr 1, 2026
ppedrot
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
…submodule. These functions make very little sense in general as they mostly ignore most invariants about terms. They are only used by plugins and thankfully never in the kernel. Their main use seems to treat constr as a first-order data type with an otherwise unspecified representation.
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
constr-type-as-first-order-data
branch
from
c86b3ae to
050910b
Compare
coqbot-app
Bot
removed
the
request: full CI
Contributor
|
@coqbot merge now |
Contributor
|
@SkySkimmer: Please take care of the following overlays:
|
SkySkimmer
added a commit
to rocq-community/aac-tactics
that referenced
this pull request
Apr 1, 2026
SkySkimmer
added a commit
to rocq-community/stalmarck
that referenced
this pull request
Apr 1, 2026
ppedrot
added a commit
to rocq-prover/equations
that referenced
this pull request
Apr 1, 2026
Janno
added a commit
to Mtac2/Mtac2
that referenced
this pull request
Apr 2, 2026
ckeller
pushed a commit
to smtcoq/smtcoq
that referenced
this pull request
Apr 2, 2026
ppedrot
added a commit
to ppedrot/coq
that referenced
this pull request
Apr 3, 2026
This is a follow-up of rocq-prover#21863. Since it is clear that these functions are only used by plugins to manipulate terms as blobs, we should not try to be too clever by half, so we just ignore the aliasing quotient.
proux01
pushed a commit
to proux01/itauto
that referenced
this pull request
Apr 10, 2026
proux01
pushed a commit
to proux01/itauto
that referenced
this pull request
Apr 10, 2026
Adapt w.r.t. rocq-prover/rocq#21863. See merge request fbesson/itauto!21
ppedrot
added a commit
to ppedrot/coq
that referenced
this pull request
May 6, 2026
This is a follow-up of rocq-prover#21863. Since it is clear that these functions are only used by plugins to manipulate terms as blobs, we should not try to be too clever by half, so we just ignore the aliasing quotient.
ppedrot
added a commit
to ppedrot/coq
that referenced
this pull request
May 11, 2026
This is a follow-up of rocq-prover#21863. Since it is clear that these functions are only used by plugins to manipulate terms as blobs, we should not try to be too clever by half, so we just ignore the aliasing quotient.
FloraStorm
pushed a commit
to FloraStorm/rocq
that referenced
this pull request
May 18, 2026
This is a follow-up of rocq-prover#21863. Since it is clear that these functions are only used by plugins to manipulate terms as blobs, we should not try to be too clever by half, so we just ignore the aliasing quotient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions make very little sense in general as they mostly ignore most invariants about terms. They are only used by plugins and thankfully never in the kernel. Their main use seems to treat constr as a first-order data type with an otherwise unspecified representation.
Overlays: