Skip to content

made native compilation compile to malfunction#22136

Draft
IBBXEF wants to merge 76 commits into
rocq-prover:masterfrom
IBBXEF:master
Draft

made native compilation compile to malfunction#22136
IBBXEF wants to merge 76 commits into
rocq-prover:masterfrom
IBBXEF:master

Conversation

@IBBXEF

@IBBXEF IBBXEF commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Hello, thanks for your pull request!
In the future, we strongly recommend that you do not use master as the name of your branch when submitting a pull request.
By the way, you may be interested in reading our contributing guide.

@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 17, 2026
@SkySkimmer

Copy link
Copy Markdown
Contributor

@coqbot run full ci

@coqbot-app coqbot-app Bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 17, 2026
@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 17, 2026
@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@SkySkimmer

Copy link
Copy Markdown
Contributor

@coqbot run full ci

@coqbot-app coqbot-app Bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 17, 2026
@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 17, 2026
@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@coqbot-app

coqbot-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@SkySkimmer

Copy link
Copy Markdown
Contributor

@coqbot run full ci

@coqbot-app coqbot-app Bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 17, 2026
Comment thread kernel/float64_common.ml Outdated
let compile f =
Printf.sprintf "Float64.of_float (%s)" (to_hex_string f)
(* Compiles a float to malfunction code *)
let compile f = (* malfunction does not support writing -1.1, so we have to be careful *)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this function is also used by extraction, so instead of modifying it you should add a new compile_malfunction or some such thing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for pstring

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and uint63

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I fixed it !

@SkySkimmer

Copy link
Copy Markdown
Contributor

not sure what's going on with 32bit
stdlib_test and metarocq are failing because of the "compile" functions used by extraction, cf my previous comments
mathcomp gets a stack overflow in malfunction, IDK if mathcomp is expected to work with native compile though (mathcomp_test disables it but mathcomp itself keeps it enabled)

@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jun 18, 2026
@SkySkimmer

Copy link
Copy Markdown
Contributor

can't rerun CI until you rebase

@coqbot-app

coqbot-app Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor.

@coqbot-app coqbot-app Bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels Jun 19, 2026
@IBBXEF

IBBXEF commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

I rebased my branch

@SkySkimmer

Copy link
Copy Markdown
Contributor

@coqbot run full ci

@coqbot-app coqbot-app Bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants