Put trakt back in CI#22137
Conversation
Trakt was about to be added to Rocq CI but for some health problems I was not able to finish it. Now it compiles again on Rocq master, and also got nice software engineering improvements on its own. Note: smtcoq_trakt is not required to be in the CI anymore. Note: @lafeychine is now a maintainer of trakt. Fixes rocq-trakt/trakt#19
|
Hello, thanks for your pull request! |
|
I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor. |
|
I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor. |
|
@coqbot run full ci |
|
Apparently trakt depends on Stdlib and elpi, we should thus ensure it is tested in both CI before merging this (otherwise a change in Stdlib or elpi could break Rocq CI). elpi's CI seems to be good, we still have to update the CI of the Stdlib library. |
Should I do it on my side? |
|
I can do it if you can wait by the end of the week. |
|
Sure, we are not in a hurry :-) |
|
I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor. |
|
@coqbot run full ci |
|
@proux01 can you self assign this PR? then when the stdlib side is ready you can merge both at the same time |
|
Stdlib done rocq-prover/stdlib#280 , let's merge here @coqbot merge now |
Trakt was about to be added to Rocq CI but for some health problems I was not able to finish it. Now it compiles again on Rocq master, and also got nice software engineering improvements on its own.
Note: smtcoq_trakt is not required to be in the CI anymore.
Note: @lafeychine is now a maintainer of trakt.
Fixes rocq-trakt/trakt#19