A subtle bug in tclWITHHOLES.#693
Merged
Merged
Conversation
This fixes Théo's bug on eset.
herbelin
force-pushed
the
v8.6+fix-set-evars-theo-bug
branch
from
dc4a800 to
1a169b0
Compare
Member
Author
|
Failed with "The job exceeded the maximum time limit for jobs, and has been terminated." |
Member
|
@herbelin Are you sure that you are talking about this PR? If yes, did you restart the full build? You could have restarted just the job that failed. |
Contributor
Member
|
Travis succeeded, so the compatibility looks good. I'm not so sure about the code, may @ppedrot can have a quick look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes bug noticed by Théo on tactic
set(see #248).