fix: reject empty normalized case slugs - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new,add, andshowwithout creating or mutating.clipcase/caseVerification
npm run release:check;bash scripts/validate.sh;git diff --checkRoger Chappel <miscanalysis@gmail.com>as author and committerRisk Level
Notes: Valid identifiers retain their existing slug normalization. Punctuation-only identifiers now fail with
Invalid case nameinstead of aliasing the literalcaseslug.Commit-by-commit:
test: cover empty case slugsadds CLI and library regression coverage.fix: reject empty normalized case slugsvalidates before storage reads or writes and preserves validation errors.docs: define accepted case identifiersdocuments the allowed slug characters and normalization rules.Rollback Plan
Human Decision Needed