Repository navigation
feat: state package-level static scope on every comparison output - #44
Merged
Merged
Conversation
Pilot feedback from dsh-wechat's maintainer: the diff's coverage of package-level static behavior only — composed-DSH-profile and host-version behavior (runtime service contracts, registered tools/commands, ctx.inject) being invisible from the package alone — was buried in coverage limitations. Every dsh-vet diff output and every PR comparison section now states the scope explicitly, comparable and incomparable alike.
dsh-vet reportGrade: A · coverage: unknown · audited
Findings
2 info findings (never affect the grade)
Findings are signals, not verdicts — a low-confidence finding never lowers a grade. A finding you believe is wrong? Open a public dispute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acting on the first external pilot reply (pan17/dsh-wechat#7): the package-level-static-only scope was stated only inside
coverage.limitations; the maintainer asked for it visible on the result itself.Every
dsh-vet diffhuman output and every PR comparison section — comparable and incomparable alike — now carries:Same sentence across the CLI renderer (
src/render-diff.ts) and the Action's dependency-free renderer (action/scripts/render.mjs); tests assert it on both paths; the pilot record's action item marked addressed.Verification:
pnpm verify— 196 tests across 17 files, typecheck, build, and package checks pass.