fix: core reliability — atomic link writes, conservative metadata, cache synchronization - #179
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements part A (A1–A3) of the 1.0.0 release readiness plan (
docs/superpowers/plans/2026-09-13-v1-core-reliability.md), three commits in dependency order:fix: preserve concurrent edits during link fixes— link fixes now transform content insidevault.processinstead of read-then-modify, so an edit committed between read and write is preserved. Deterministic concurrency regression included; failure matrix covers rejected writes and vanished targets.fix: withhold link fixes when target metadata is unavailable— a null target cache (not yet indexed) no longer produces a confirmed broken-link finding with an executable fix; it reports unverified/info withevidence.reason: target-metadata-unavailableand no fix action. An empty-but-present cache is still treated as real evidence.COMPARISON_VERSION3 → 4 isolates older baselines (comment covers both the fix: stop flagging unverifiable and hashless block links as broken #174 block semantics and this change, per the increment-once rule). Adapted to the post-fix: stop flagging unverifiable and hashless block links as broken #174/fix: match Obsidian heading anchors by substituting non-alphanumerics with spaces #176 code structure as recorded in the plan's execution note.fix: defer verification until mutation metadata is ready— newMetadataWriteFencecorrelates each mutation with the exactchanged+resolvedcache events (anddeleted/absence for trash) before verification proceeds; timeouts poison the batch so later preflights are skipped instead of reading stale metadata, with the recovery message the runner surfaces. No CLI schema changes.Validation
npm run lint && npm run lint:obsidian-warnings && npm run build && npm test && npm pack --dry-run— 949 tests pass.