feat: resolve issues #125 #152 #154 #156#228
Merged
Merged
Conversation
|
@JONAH-6 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four issues: database performance, device-based fraud detection, external webhook integration, and admin
observability.
transfers,audit_logs,users, andledger_entriesand trigger step-up auth
5-attempt exponential retry with jitter, dead-letter status, and secret rotation
admin routes; expose
GET /admin/auditlistingChanges
Database (migrations/)
004_optimize_indexes.sql— composite, partial, and unique indexes for frequent query patterns005_webhooks.sql—webhooksandwebhook_deliveriestables with indexes006_admin_audit.sql—admin_audit_logstable with indexesBackend (src/)
auth/deviceFingerprint.ts— SHA-256 fingerprint generator (user-agent + accept-* headers + IP)auth/riskEngine.ts— fingerprint-aware device tracking;fingerprintfield onAuthEventmodules/webhooks/webhookService.ts— webhook CRUD, EventBus integration, SSRF validation, HMAC timestamp-signeddelivery, 5-attempt exponential retry with jitter, dead-letter, secret rotation
modules/admin/adminAuditService.ts— admin action log storemiddleware/adminAudit.ts—createAdminAuditHook(action)factory for Fastify preHandlerroutes/webhooks.ts— webhook management endpoints including secret rotation and manual delivery retryroutes/auth.ts— fingerprint extraction and injection into auth eventsroutes/admin.ts— audit hooks on mutating routes;GET /admin/auditandGET /admin/audit/:idcontainer.ts— registerwebhooks,adminAudit,authRiskEngine, and other previously-untyped services incontainer interface and factory
Closes
Closes #125
Closes #152
Closes #154
Closes #156