feat: goal-based savings tracking & milestones (#133)#688
Open
zacharylyonstx wants to merge 1 commit intorohitdash08:mainfrom
Open
feat: goal-based savings tracking & milestones (#133)#688zacharylyonstx wants to merge 1 commit intorohitdash08:mainfrom
zacharylyonstx wants to merge 1 commit intorohitdash08:mainfrom
Conversation
Backend (Flask): - SavingsGoal, SavingsGoalMilestone, SavingsGoalContribution models - CRUD endpoints: GET/POST /savings-goals, GET/PUT/PATCH/DELETE /savings-goals/<id> - POST /savings-goals/<id>/contribute with milestone auto-detection - GET /savings-goals/<id>/milestones - Auto-generated milestones at 25%, 50%, 75%, 100% - Progress calculation and time-based projections (daily/monthly targets) - Input validation with descriptive error messages - PostgreSQL schema migration in schema.sql Frontend (React): - SavingsGoals page with overview cards (total saved, active, completed, progress) - Goal list with progress bars, milestone dot indicators, category badges - Create/edit goal dialog with name, target, deadline, category - Contribute to goal modal with amount and optional note - Visual milestone celebration overlay with animations - Navigation link added to Navbar - Route added to App.tsx with ProtectedRoute wrapper Tests: - 6 backend unit tests covering CRUD, contributions, milestones, validation, 404s - 6 frontend integration tests covering rendering, empty state, progress, milestones - All 33 frontend tests pass, backend tests pass in CI (requires Redis)
Author
|
@rohitdash08 Savings Goals feature is ready for review — complete with milestones, backend CRUD, React dashboard, and tests. Happy to iterate on any feedback! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Goal-based savings tracking & milestones as described in #133.
Backend (Flask)
SavingsGoal,SavingsGoalMilestone,SavingsGoalContributionmodelsGET/POST /savings-goals,GET/PUT/PATCH/DELETE /savings-goals/<id>POST /savings-goals/<id>/contributewith milestone auto-detectionGET /savings-goals/<id>/milestonesschema.sqlFrontend (React)
Tests
Closes #133