docs: how a reply to a contributor is written, and the older bug #13 surfaced - #20
Merged
Merged
Conversation
…surfaced Two things this release's first outside PR turned up that were not in its diff. CONTRIBUTING gains "How the reply is written". The reply goes out under a person's name to a person, and the rules that keep it reading that way were being carried in somebody's head: no dashes, none of the assistant tells, say what a declined fix lost to rather than leaving them to guess, thank them for the specific thing. The section is written to its own rules so there is a worked example in the file. The CHANGELOG entry for the Gemini fixes says how old the first one is. google-genai has validated function declarations since 2.x, so the schema bug refused every verb call on every robot for every Gemini model, not only Gemini 3. It survived because 0.8.0's "default model IDs are unverified" bullet was true to the letter: Gemini's default had never been sent a request from here. Credit to @Bayway, per rule 5, which says older breakage a review surfaces gets fixed and said out loud in the same release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things #13 turned up that were not in its diff.
CONTRIBUTING gains "How the reply is written"
The reply to a contributor goes out under a person's name, to a person. The rules that keep it reading that way were being carried in somebody's head rather than written down, which meant they had to be said out loud again:
google-genai,gemini-3.8-flash,--provider, branch names, identifiers)The section is written to its own rules, so the file carries a worked example of the thing it is asking for. Verified: it contains no em dash, no en dash, and its only hyphens are inside a package name, a model id and a CLI flag.
The CHANGELOG says how old the Gemini bug is
Rule 5 says older breakage a review surfaces gets fixed and said out loud in the same release, rather than left for later.
google-genai has validated function declarations since 2.x, so the
exclusiveMinimumbug refused every verb call on every robot for every Gemini model, not only Gemini 3. It survived because 0.8.0's own "non-Anthropic default model IDs are unverified" bullet was true to the letter: Gemini's default had never been sent a request from here. A--providernobody runs is a--providernobody finds the bugs in.Credit added to @Bayway (#13), who ran it.
Gate
tests/test_docs.pyandtests/test_catalogue.pypass, which are the two suites that read these files.🤖 Generated with Claude Code