Repository navigation
Detect three-line List rows on web (PoC) - #1
Closed
adam-sajko wants to merge 1 commit into
Closed
adam-sajko wants to merge 1 commit into
adam-sajko wants to merge 1 commit into
Conversation
|
Found potential problems with the pull request:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PoC on top of this branch: the three line 12dp tier relies on
onTextLayout, whichdoes not exist on web. This measures the description instead, so the tier works there too.
Same change as callstack#5091, opened here so the diff is the PoC alone.
Related issue
Related to callstack#4976
Test plan
Run the example on web, open the List screen and check a row with a wrapping
description gets the three line padding.