fix(camp): close GDAL/OGR handle leaks in chart/vector loading (#152)

[rolker]

Summary

Closes #152. Every chart load leaked GDAL/OGR handles, valgrind-confirmed at ~180 KB of OGR/PROJ state per Georeferenced instance, growing monotonically across a session.

Two leak sites fixed:

1. Georeferenced had no destructor — its two OGRCoordinateTransformation members (created in extractGeoreference) leaked per DepthRaster / VectorDataset. Added a virtual ~Georeferenced() that DestroyCTs both.
   • Why virtual: defensive future-proofing — today neither subclass is deleted through a Georeferenced* (DepthRaster as DepthRaster*, VectorDataset via the QObject parent chain), so the dtor runs regardless; virtual keeps delete-through-base correct if that ever changes.
   • Rule-of-three: = delete copy ctor/assignment now that the class owns handles (both subclasses are heap-only, so no live call site changes).
2. VectorDataset::open never GDALClosed the dataset, never destroyed the per-layer transformation, and never destroyed any OGRPointIterator. Fixes: RAII-close the dataset; per-layer transformation freed by RAII (unique_ptr + DestroyCT deleter) at end-of-layer (previously all but the last layer leaked); every iterator destroyed at its site, including the interior-ring iterator inside the ring loop.

Testable seam (refactor)

open() interleaved the GDAL/OGR resource lifecycle with building the project item graph (Point/LineString/Polygon + connect(autonomousVehicleProject(), …)), so any test driving open() would link ~all 52 app TUs and stand up a QApplication-backed AutonomousVehicleProject. The pure parse is split into a MissionItem-free TU:

• vector/vector_parse.{h,cpp} — camp::vector::parseVectorLayers(GDALDataset*) returns plain WGS84 geometry (ParsedLayer/ParsedGeometry) and owns the transform + iterator lifecycle.
• open() → RAII-open dataset, extractGeoreference, then buildItems(parseVectorLayers(...)).
• buildItems holds the unchanged item-graph construction; per-geometry coordinate handling preserved verbatim.

Tests

• test_vector_dataset_cleanup (new) — links the standalone vector_parse TU (no item graph); synthetic 2-layer GeoPackage (point + linestring + polygon-with-hole per layer) exercises every parse/iterator site; asserts the parse is non-vacuous and the GDAL open-dataset count returns to baseline.
• test_depth_raster — added a baseline-delta test guarding the pre-existing DepthRaster GDALClose.

The OGRCoordinateTransformation handles (the primary ~180 KB leak) are not visible to GetOpenDatasets(), so they are proven closed under valgrind:

test_vector_dataset_cleanup:  definitely lost: 0 bytes in 0 blocks
                              indirectly lost: 0 bytes in 0 blocks
test_depth_raster:            definitely lost: 0 bytes in 0 blocks
                              indirectly lost: 0 bytes in 0 blocks

Full package suite: 154 tests, 0 failures.

Review

Local pre-push review (/run-issue): approved, Ship: recommended (zero must-fix; two adversarial passes confirmed behavior-preserving + leak-free). Two review suggestions folded (RAII exception-safety on the per-layer transform; corrected the ~Georeferenced comment); the third (attach valgrind output) is the block above.

---

Authored-By: Claude Code Agent
Model: Claude Opus 4.8

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.