Add root AGENTS.md (review-instructions pilot)#101
Merged
Conversation
Instantiated from ros2_agent_workspace's project_agents_md.md template (ADR-0017: reference, never fork). Closes #100
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a root-level AGENTS.md intended to provide repository-specific instructions to GitHub Copilot code review and other “closest-file-wins” coding agents, with an emphasis on robustness and CUBE algorithm fidelity considerations.
Changes:
- Introduces workspace context and a “do not fork shared rules” policy (references workspace root rules).
- Defines review expectations emphasizing robustness (tests, validation, lifecycle correctness).
- Adds CUBE-specific review context (algorithm fidelity, unit/sign vigilance, data retention, CI image/workflow sync).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+6
| Copilot code review**, which reads this file when reviewing PRs. There is no | ||
| `.agents/README.md` deep guide yet; start from the top-level `README.md` and | ||
| `docs/` (including this repo's ADRs under `docs/decisions/`). |
| elevations, dB conventions, and transmission-loss corrections have all | ||
| produced sign bugs before; intensity statistics ride Welford accumulators | ||
| where order-independence and merge semantics matter. | ||
| - **Survey data is never lost to bound memory**: draft-tile eviction |
Comment on lines
+53
to
+55
| - **CI is industrial_ci with a prebaked GHCR deps image**: `ci.yml` and | ||
| `.github/ci/Dockerfile` must stay in sync — dependency changes usually | ||
| touch both. |
Comment on lines
+5
to
+8
| `.agents/README.md` deep guide yet (the workspace convention for project | ||
| agent guides — distinct from the `.agent/work-plans/` directory); start from | ||
| the top-level `README.md` and `docs/` (including this repo's ADRs under | ||
| `docs/decisions/`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root
AGENTS.md— read by GitHub Copilot code review and closest-file-winscoding agents. Workspace template (ADR-0017) plus CUBE-specific review
context: algorithm fidelity as a review dimension, sign/unit vigilance,
never-lose-data eviction rule, industrial_ci image sync.
Closes #100
Part of rolker/ros2_agent_workspace#563 (pilot 7/7, FP baseline 8)
Authored-By:
Claude Code AgentModel:
Claude Fable 5