Skip to content

Onboard repo with workspace standards#42

Merged
rolker merged 2 commits into
jazzyfrom
feature/issue-39
Jul 15, 2026
Merged

Onboard repo with workspace standards#42
rolker merged 2 commits into
jazzyfrom
feature/issue-39

Conversation

@rolker

@rolker rolker commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

Add workspace-standard infrastructure (onboarding campaign rolker/unh_marine_autonomy#264, tier-1 repo 3/4):

  • Pre-commit config — workspace template; protected branch jazzy. Python hooks left off: the repo's Python is dev tooling (doc config, launch file, manual-run mininet scripts), not shipped modules.
  • CI workflowros:jazzy-ros-core container, colcon build + gtest suite (109 tests). All dependencies resolve via rosdep — no source-sibling clones. Linter-labeled tests are excluded (--ctest-args -LE linter) until license headers land — tracked in Add license headers to source files and re-enable linters in CI #40, same pattern as Add BSD license headers to source files unh_marine_navigation#98. Verified locally in the worktree: build clean, 109/109 tests pass.
  • Agent guide (.agents/README.md) — source-verified per the documentation-verification workflow: parameters read from on_configure, services/QoS from the create_service/create_publisher calls, threading invariants from the udp_bridge_node.cpp header comment, the UDP_BRIDGE_BUILD_TESTING ODR discipline from CMakeLists. The verification pass surfaced six stale claims in the existing user-facing docs (nonexistent remotes.<label>.name parameter, wrong rate-limit default, inverted service semantics, ...) — tracked separately in Fix README/example_params drift: nonexistent name param, wrong rate default, service table #41; this guide documents the verified behavior.
  • Root AGENTS.md touch-up — the "no deep guide yet" intro now points at the new guide.

Done via API (no file change): pkg: labels for both packages, git-bug bridge.
Deferred: license headers + linter re-enable (#40), user-facing doc drift (#41).

Closes #39


Authored-By: Claude Code Agent
Model: Claude Fable 5

Onboarding: pre-commit config, CI workflow (colcon build + gtest suite,
fully rosdep-resolvable, linter-labeled tests excluded pending #40),
source-verified agent guide (.agents/README.md), and root AGENTS.md
pointer updated now that the deep guide exists.

Closes #39
Copilot AI review requested due to automatic review settings July 15, 2026 15:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR onboards udp_bridge to the workspace-standard developer infrastructure for the jazzy default branch, adding repo-local automation (pre-commit + CI) and a source-verified agent guide to help future changes stay aligned with the system’s operational constraints (lossy telemetry link, lifecycle behavior, threading/locking invariants).

Changes:

  • Add a workspace-template-based pre-commit configuration (with ROS-friendly YAML checks and jazzy branch protection hook).
  • Add a GitHub Actions CI workflow using ros:jazzy-ros-core to colcon build and run tests (excluding linter-labeled tests per #40).
  • Add a new .agents/README.md agent guide and update root AGENTS.md to point to it.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
AGENTS.md Updates the root agent pointer text to direct coding agents to the new deep guide.
.pre-commit-config.yaml Introduces workspace-standard pre-commit hooks (YAML/XML checks, cmake lint, yamllint, and no-commit-to-branch for jazzy).
.github/workflows/ci.yml Adds container-based Jazzy CI that installs deps via rosdep, builds, and runs tests with linter exclusions.
.agents/README.md Adds a detailed, source-verified agent guide describing architecture, parameters, topics/services, and operational pitfalls.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/README.md
Comment on lines +58 to +60
`udp_bridge_node` runs a `MultiThreadedExecutor` (8 threads) with three
callback groups whose invariants are documented at the top of
`src/udp_bridge_node.cpp`:
The periodic group hosts six service handlers since the remove_* pair
was added. Flagged by Copilot review on #42; was item 6 of #41.
Copilot AI review requested due to automatic review settings July 15, 2026 16:27
@rolker

rolker commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

Review triage — Copilot finding

Valid catch: the guide pointed at the udp_bridge_node.cpp top comment, which still said "four service handlers" (pre-remove_* drift; was item 6 of #41). Rather than acknowledging the drift in the guide, f12b650 fixes the source comment itself — six handlers, all listed. #41 item 6 is thereby resolved in this PR; items 1–5 (user-facing README/example YAML) remain tracked there.


Authored-By: Claude Code Agent
Model: Claude Fable 5

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread .pre-commit-config.yaml
Comment on lines +15 to +16
- id: check-yaml
args: ['--unsafe'] # allow ROS YAML tags
@rolker rolker merged commit 95982a0 into jazzy Jul 15, 2026
2 checks passed
@rolker rolker deleted the feature/issue-39 branch July 15, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Onboard repo with workspace standards

2 participants