Onboard repo with workspace standards#46
Merged
Merged
Conversation
Onboarding: pre-commit config, CI workflow (colcon build + test incl. the bag-replay launch tests, marine_control sibling clone), root AGENTS.md (ADR-0017), source-verified agent guide (.agents/README.md), and a sea_surface_segmentation package.xml description fix (typo + understated scope). Closes #43
There was a problem hiding this comment.
Pull request overview
This PR onboards unh_marine_perception to the workspace’s standard infrastructure by adding CI + pre-commit configuration and introducing agent-facing repository guidance, along with a small metadata fix in package.xml.
Changes:
- Add a GitHub Actions CI workflow to build + test the ROS 2 packages in a containerized Jazzy environment (including bag-replay launch tests).
- Add workspace-template pre-commit hooks for basic hygiene checks (YAML/XML/CMake lint, large-file guard, protected branch guard).
- Add repo-level AI/agent guidance (
AGENTS.mdand.agents/README.md) plus improvesea_surface_segmentationpackage metadata.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sea_surface_segmentation/package.xml |
Updates the package description to reflect actual shipped components. |
AGENTS.md |
Adds repo-specific agent/review context and safety framing. |
.pre-commit-config.yaml |
Introduces workspace-standard pre-commit checks (without Python formatting hooks for now). |
.github/workflows/ci.yml |
Adds CI to build/test both packages in ros:jazzy-ros-core with a source-sibling dependency clone. |
.agents/README.md |
Adds a source-verified agent guide with architecture, safety, and testing notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+29
| - name: Install ros dev tools | ||
| run: DEBIAN_FRONTEND=noninteractive apt-get -y install ros-dev-tools | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
Comment on lines
+11
to
+14
| The workspace root `AGENTS.md` carries the full shared rules (worktree | ||
| isolation, issue-first policy, commit conventions, AI signatures). This file | ||
| **references** those rules and adds repo-specific context only — it must | ||
| never restate or fork them. |
Owner
Author
Review triage — Copilot findingsBoth findings are false positives:
No changes needed. Authored-By: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add workspace-standard infrastructure (onboarding campaign rolker/unh_marine_autonomy#264, tier-2 repo 1):
jazzy; black/flake8 deferred with Add license headers to source files (+ LICENSE file check, Python lint hooks) #44.ros:jazzy-ros-core, colcon build + test of both packages with one sibling clone (marine_control, for the ADR-0003 device-control wiring). The test step includes the launch_testing integrations that replay the in-repo bag fixture — no camera hardware needed. Verified in an isolated CI-equivalent workspace: build clean, 98/98 tests pass including both bag-replay launch tests. No ament linters wired, so no exclusion needed.AGENTS.md(ADR-0017 — this repo wasn't in the pilot wave) — Review Context flags the safety framing: segmentation feeds costmap layers and the Collision Monitor reflex, so timestamp/frame handling deserves close review..agents/README.md, source-verified) — node/plugin inventory, the device-capture-time stamping story (Segmentation output stamped with now() instead of frame capture time (~123 ms late) → stale pose, buoy misses costmap #28), the 0.95 reflex-confidence cap rationale, the marine_control device exposure ofobstacle_prob_min, and the bag-replay test pattern. The verification pass surfaced four docs-drift items — tracked in Fix README/docs drift: missing params in tables, stale h265 timing description, legacy launch tooling #45.Done via API (no file change):
pkg:labels for both packages, git-bug bridge.Deferred: license headers + missing LICENSE file (#44), docs drift (#45).
Closes #43
Authored-By:
Claude Code AgentModel:
Claude Fable 5