Skip to content

Onboard repo with workspace standards#46

Merged
rolker merged 1 commit into
jazzyfrom
feature/issue-43
Jul 15, 2026
Merged

Onboard repo with workspace standards#46
rolker merged 1 commit into
jazzyfrom
feature/issue-43

Conversation

@rolker

@rolker rolker commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

Add workspace-standard infrastructure (onboarding campaign rolker/unh_marine_autonomy#264, tier-2 repo 1):

  • Pre-commit config — workspace template; protected branch jazzy; black/flake8 deferred with Add license headers to source files (+ LICENSE file check, Python lint hooks) #44.
  • CI workflowros:jazzy-ros-core, colcon build + test of both packages with one sibling clone (marine_control, for the ADR-0003 device-control wiring). The test step includes the launch_testing integrations that replay the in-repo bag fixture — no camera hardware needed. Verified in an isolated CI-equivalent workspace: build clean, 98/98 tests pass including both bag-replay launch tests. No ament linters wired, so no exclusion needed.
  • Root AGENTS.md (ADR-0017 — this repo wasn't in the pilot wave) — Review Context flags the safety framing: segmentation feeds costmap layers and the Collision Monitor reflex, so timestamp/frame handling deserves close review.
  • Agent guide (.agents/README.md, source-verified) — node/plugin inventory, the device-capture-time stamping story (Segmentation output stamped with now() instead of frame capture time (~123 ms late) → stale pose, buoy misses costmap #28), the 0.95 reflex-confidence cap rationale, the marine_control device exposure of obstacle_prob_min, and the bag-replay test pattern. The verification pass surfaced four docs-drift items — tracked in Fix README/docs drift: missing params in tables, stale h265 timing description, legacy launch tooling #45.
  • package.xml fix — sea_surface_segmentation description had a typo ("compines") and understated the package (it also ships the costmap plugins and the reflex adapter).

Done via API (no file change): pkg: labels for both packages, git-bug bridge.
Deferred: license headers + missing LICENSE file (#44), docs drift (#45).

Closes #43


Authored-By: Claude Code Agent
Model: Claude Fable 5

Onboarding: pre-commit config, CI workflow (colcon build + test incl.
the bag-replay launch tests, marine_control sibling clone), root
AGENTS.md (ADR-0017), source-verified agent guide (.agents/README.md),
and a sea_surface_segmentation package.xml description fix (typo +
understated scope).

Closes #43
Copilot AI review requested due to automatic review settings July 15, 2026 19:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR onboards unh_marine_perception to the workspace’s standard infrastructure by adding CI + pre-commit configuration and introducing agent-facing repository guidance, along with a small metadata fix in package.xml.

Changes:

  • Add a GitHub Actions CI workflow to build + test the ROS 2 packages in a containerized Jazzy environment (including bag-replay launch tests).
  • Add workspace-template pre-commit hooks for basic hygiene checks (YAML/XML/CMake lint, large-file guard, protected branch guard).
  • Add repo-level AI/agent guidance (AGENTS.md and .agents/README.md) plus improve sea_surface_segmentation package metadata.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sea_surface_segmentation/package.xml Updates the package description to reflect actual shipped components.
AGENTS.md Adds repo-specific agent/review context and safety framing.
.pre-commit-config.yaml Introduces workspace-standard pre-commit checks (without Python formatting hooks for now).
.github/workflows/ci.yml Adds CI to build/test both packages in ros:jazzy-ros-core with a source-sibling dependency clone.
.agents/README.md Adds a source-verified agent guide with architecture, safety, and testing notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines +24 to +29
- name: Install ros dev tools
run: DEBIAN_FRONTEND=noninteractive apt-get -y install ros-dev-tools

- name: Checkout
uses: actions/checkout@v6

Comment thread AGENTS.md
Comment on lines +11 to +14
The workspace root `AGENTS.md` carries the full shared rules (worktree
isolation, issue-first policy, commit conventions, AI signatures). This file
**references** those rules and adds repo-specific context only — it must
never restate or fork them.
@rolker

rolker commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

Review triage — Copilot findings

Both findings are false positives:

  1. git not present in the container — the "Install ros dev tools" step (ros-dev-tools) installs git before checkout; the checkout and the marine_control clone succeeded in the green run on this PR (run 29443125297). Same documented template false positive as Onboard repo with workspace standards camp#166 and the nav onboarding (see the campaign notes at Onboarding campaign: bring first-party project repos to workspace standards unh_marine_autonomy#264).
  2. AGENTS.md "never restate" vs the Quality Standard excerpt — intentional and self-documenting: the HTML comment directly above the excerpt states it is a deliberately condensed standalone excerpt for repos reviewed without workspace context, with re-sync guidance, and that workspace ADR-0017 explicitly acknowledges this drift trade-off. The "never restate or fork" sentence governs the rest of the shared rules (worktrees, issue policy, commit conventions), which this file only references. Identical wording ships in the 7 ADR-0017 pilot repos.

No changes needed.


Authored-By: Claude Code Agent
Model: Claude Fable 5

@rolker
rolker merged commit 68d6a73 into jazzy Jul 15, 2026
2 checks passed
@rolker
rolker deleted the feature/issue-43 branch July 15, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Onboard repo with workspace standards

2 participants