Repository navigation
Conversation
👷 Deploy request for tsdown-main pending review.Visit the deploys page to approve it
|
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change to stabilize glob-expanded entry ordering.
No open issues 🎉
What changed in this PR
This PR stabilizes glob-expanded entry ordering in tsdown to address non-deterministic declaration import order caused by filesystem traversal differences.
Changes:
- Sort glob results for array entries and within each object-entry key.
- Add regression tests using reversed glob results and verify that explicit entry order remains unchanged.
| File | Description |
|---|---|
src/features/entry.ts |
Sorts glob-expanded paths before constructing entries. |
src/features/entry.test.ts |
Tests stable glob ordering and preservation of explicit entry order. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm getting non-deterministic builds with tsdown with import order in d.ts files differing between invocations. My AI tracked this down to that glob results may arrive in different filesystem traversal orders between builds. Passing that order through to Rolldown changes the ordering of emitted imports, producing different declaration files from unchanged sources.
This PR fixes this by slapping a sort on the glob results.
Linked Issues
Maybe related: rolldown/rolldown#10227
Additional context