Skip to content

fix: hide Rolldown's MIXED_EXPORTS warning when cjsDefault is on - #1131

Merged
sxzz merged 1 commit into
mainfrom
fix/mixed-exports-code
Nov 12, 2026
Merged

sxzz merged 1 commit into
mainfrom
fix/mixed-exports-code

Conversation

@hyfdev

@hyfdev hyfdev commented Nov 12, 2026

Copy link
Copy Markdown
Member

With cjsDefault, tsdown means to hide Rolldown's mixed-exports warning.

The check compares against MIXED_EXPORT, so it never matches.

Rolldown renamed the code to MIXED_EXPORTS in rolldown/rolldown#7565.

After rolldown/rolldown#11218, Rolldown also reports it for non-entry modules under unbundle.

This PR checks for the current code.

@netlify

netlify Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for tsdown-main ready!

Name Link
🔨 Latest commit c5b7bf2
🔍 Latest deploy log https://app.netlify.com/projects/tsdown-main/deploys/6af5141ab2fab4b19842a339
😎 Deploy Preview https://deploy-preview-1131--tsdown-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown@1131 -D
npm i https://pkg.pr.new/rolldown/tsdown@1131 -D
yarn add https://pkg.pr.new/rolldown/tsdown@1131.tgz -D

create-tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1131 -D
npm i https://pkg.pr.new/rolldown/tsdown/create-tsdown@1131 -D
yarn add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1131.tgz -D

@tsdown/css

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1131 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1131 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1131.tgz -D

@tsdown/exe

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1131 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1131 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1131.tgz -D

tsdown-migrate

pnpm add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1131 -D
npm i https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1131 -D
yarn add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1131.tgz -D

commit: c5b7bf2

@hyfdev
hyfdev marked this pull request as ready for review November 12, 2026 02:22
Copilot AI balanced review requested due to automatic review settings November 12, 2026 02:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@sxzz
sxzz merged commit e2e174d into main Nov 12, 2026
19 checks passed
@sxzz
sxzz deleted the fix/mixed-exports-code branch November 12, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants