Repository navigation
Conversation
👷 Deploy request for tsdown-main pending review.Visit the deploys page to approve it
|
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
css.injectalways prepended an ESMimport '...'statement, so CJS chunks gotimport './style.css';— invalid CommonJS. The injected statement now follows the output format:require('...')for CJS and the previousimport '...'for ESM.The same problem existed for the shared CSS-only chunk rewrite in
splittingmode: the regex only matchedimport '...', so in CJS a chunk keptrequire('./shared-xxx.cjs')for a chunk that is later removed, and the emitted CSS asset was never referenced. That require is now rewritten to the.cssfile as well.Linked Issues
Fixes #1135
Additional context
Validation:
pnpm vitest run— 37 files, 564 passed, 4 expected fail, 4 skippedpnpm typecheckpnpm exec eslint packages/css/src/plugin.ts tests/css.test.tspnpm exec prettier --check packages/css/src/plugin.ts tests/css.test.tsTwo regression tests were added under
css.inject: a plain CJS entry and a CJS build withsplitting: truethat reuses a shared CSS-only chunk. Both fail onmainand pass with this change.