Modernize the code base#338
Merged
Merged
Conversation
sstok
force-pushed
the
refactor/modernize
branch
from
5d8ee91 to
2206b9b
Compare
Contributor
Author
|
I guess we can drop support for PHP 8.1, and require PHP 8.2 instead? |
sstok
force-pushed
the
refactor/modernize
branch
7 times, most recently
from
3765bdc to
88d823c
Compare
sstok
commented
Mar 12, 2026
sstok
force-pushed
the
refactor/modernize
branch
5 times, most recently
from
35ccdbd to
3a4af18
Compare
- Use modern callbacks - Reduce code some complexity - Use match instead of switch - Ensure proper serializing error handling - Fix changes of type errors - Fix order of providers (in tests)
When no default entity is provided and no default was set this would have failed with a runtime TypeError
The ordering was not considered part of a condition being non-empty Add tests to verify general behavior
sstok
force-pushed
the
refactor/modernize
branch
from
3a4af18 to
559d12e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Passing
nullfor grouping and round is deprecated, it's better to make this implicit behavior explicit.